Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to .NET 9.0 #538

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Update to .NET 9.0 #538

wants to merge 2 commits into from

Conversation

yaakov-h
Copy link
Member

This PR updates DepotDownloader to build for .NET 9.0 RC1.

@@ -30,7 +30,7 @@ jobs:
- name: Setup .NET Core
uses: actions/setup-dotnet@v4
with:
dotnet-version: 8.0.x
global-json-file: global.json
Copy link
Member

@xPaw xPaw Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably works by default without explicitly specifying it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs don't indicate this but it is worth trying

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actions yaml wording sounded like it does. Looked at the code and it indeed does:

https://github.com/actions/setup-dotnet/blob/3e891b0cb619bf60e2c25674b222b8940e2c1c25/src/setup-dotnet.ts#L23-L32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants